Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Search #246

Draft
wants to merge 43 commits into
base: faceted-search
Choose a base branch
from
Draft

Advanced Search #246

wants to merge 43 commits into from

Conversation

almasaeed2010
Copy link
Contributor

@almasaeed2010 almasaeed2010 commented Feb 26, 2019

This PR introduces a few things:

  • Synonyms based off of WordNet
  • Stop word "tolerance"
  • Support for filtering by field in a new Advanced Search page

Missing:

  • Instructions on where to place the synonyms file
  • A checkbox to indicate whether we should apply the synonyms filter

This builds on the faceted-search branch so merge there

@almasaeed2010
Copy link
Contributor Author

When the checkbox for including synonyms is checked we need to ask the user for the file path and the format of the file. Those values can default to ./synonyms/wn_s.pl and wordnet. We also need to specify that this index supports synonyms in the tripal_elasticsearch_indices table, which would require a migration to add a new column.

@almasaeed2010
Copy link
Contributor Author

I am gonna start the indexing process on our dev server for the meeting tomorrow to see whether this functions well with large amounts of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant